Hi Willy,

On 2015/1/28 18:28, Willy Tarreau wrote:
Hi Godbach,

On Wed, Jan 28, 2015 at 05:57:13PM +0800, Godbach wrote:
Hi Willy,

Attached is a patch for parse_size_err().

If a stick table is defined as below:
        stick-table type ip size 50ka expire 300s

HAProxy will stop parsing size after passing through "50k" and return
the value directly. But such format string of size should not be valid
in my opinion. So a further check is needed, that is this patch does.

Yes, good point. We have the same issue in many statements in the config
parser, as well as with extra arguments that are silently ignored and
that tend to confuse people. That's inline with what we want to change
in the 1.6 parser.

I've applied it to 1.6, do you want it into 1.5 as well ?

Willy


Thanks.

Since it's not an important issue and will not bring much side effect, just apply to 1.6 is OK.

--
Best Regards,
Godbach

Reply via email to