On Fri, Apr 03, 2015 at 10:24:34AM +0300, gunay arslan wrote:
> Hope  this can solve your needs

Perfect, thank you. I forgot to null-terminate a list, I just pushed
the patch, here it is for you. Thanks for your detailed report!

Willy

commit cb703b0352d02e2a4e712258677ee2d296adc6dd
Author: Willy Tarreau <[email protected]>
Date:   Fri Apr 3 09:52:01 2015 +0200

    BUG/MAJOR: http: null-terminate the http actions keywords list
    
    Commit a0dc23f ("MEDIUM: http: implement http-request 
set-{method,path,query,uri}")
    forgot to null-terminate the list, resulting in crashes when these actions
    are used if the platform doesn't pad the struct with nulls.
    
    Thanks to Gunay Arslan for reporting a detailed trace showing the
    origin of this bug.
    
    No backport to 1.5 is needed.

diff --git a/src/proto_http.c b/src/proto_http.c
index d1cd042..90176fc 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -12033,6 +12033,7 @@ struct http_req_action_kw_list http_req_actions = {
                { "set-path",   parse_set_req_line },
                { "set-query",  parse_set_req_line },
                { "set-uri",    parse_set_req_line },
+               { NULL, NULL }
        }
 };
 

Reply via email to