Hi Dragan, On Mon, Jun 29, 2015 at 04:43:24PM +0200, Dragan Dosen wrote: > Hi, > > I'm sending you three patches for 51Degrees converter. > > Dragan Dosen (3): > MEDIUM: 51Degrees code refactoring and cleanup > MEDIUM: 51d: add LRU-based cache on User-Agent string detection > DOC: add notes about the "51degrees-cache-size" parameter
Thank your for this work, especially the code refactoring which must have been quite boring to do and which led to a much cleaner result! Regarding the cache, that's interesting. Have you run benchmarks to measure any performance improvements ? I remember that there are two versions of the lib, pattern and trie, the former being supposed to be slower but more memory saving than the second one. Maybe your work could make it possible to use the former without noticeable performance degradation, resulting in less memory usage ? It would be cool to port this cache to the DeviceAtlas library as well so that we have the same behaviour on both libraries. Patches merged, thanks! Willy
