Hi David, On Thu, Jul 02, 2015 at 03:13:11AM +0100, David CARLIER wrote: > Hi > > Yes indeed I sent two versions intentionally the first with T. Fournier > proposal the another one what I had in mind so at least any of them can be > chosed freely but deeply that does not change much the things it is just > "formal" ... > > 1/ Apart of popcount conflict, nothing particular that work pretty fine > otherwise.
OK thanks for clarifying. > 2/ I get your point, if Haproxy folks prefer just renaming popcount > internal function to haproxy_popcount or whatever, it is ok for me then, I > am quite open to other options :-) Yes we already have some functions prefixed with "my_" when there are known portability issues (strndup and things like this). Just mention this conflict in the commit message so that the purpose is clear. BTW, since on netbsd popcount() takes an int and popcountl() takes a long let's rename our function "my_popcountl()" so that there's no ambiguity on its args. Don't forget to change the comment at the top of nbits() to reflect the name change there as well. Regarding the addition of the netbsd target to the makefile, let's do it to make things cleaner even if in the beginning it contains the same options as openbsd. However we'll keep this 1.6-only. Thanks! Willy
