Hi Baptiste (and others),

I can confirm that the two patches applied make this work as expected for
me (first resolution at first health check, then not again until hold.valid
is elapsed). Thanks a lot!

I am still wondering if the signature of tick_* shouldn't also be changed
to unsigned int? I took another look today and it seems like it almost
exclusively used with unsigned int values (mostly derived from now_ms), and
I would expect a tick to be unsigned anyways.

I think having the interface as it is just unneccessarily invites bugs like
that one. Would be willing to take a stab at that, too, if so desired...

Anyways, thanks for all the fish,
Conrad

On 09/03/2015 11:50 AM, Baptiste wrote:
> Hi Conrad,
> 
> Please use the two patches in attachement.
> 
> Baptiste
> 

-- 
Conrad Hoffmann
Traffic Engineer

SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany

Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg |
HRB 110657B

Reply via email to