On Tue, Sep 29, 2015 at 02:01:59PM +0200, Thierry FOURNIER wrote: > Michael, thank you for the bug repport. I reproduce it. > > It is introduced with the support of the RFC5424 for the logs format > sublitted by dragan. > > Hi Dragan, after your patch about the RFC5424, the funcion __send_log() > no longer support NULL for the "*p" param. Can you fix this ? > > It seems that the 'log_htp' and the 'log_htp_rfc5424' members of the > "struct proxy" contains preformatted strings. There makeby the function > "lf_host_tag_pid()". > > Maybe, we should build a defaults strings (one for each rfc) at the > start of haproxy, and uses these default strings if the proxy "*p" is > NULL in the function "__send_log()" ?
Yes indeed we should have one of each, statically defined in log.c with the global log tag I guess. In fact this would even allow not to allocate one tag per proxy since we'd be able to reuse the global one when a proxy defines no log-tag. Thanks Thierry for the diag. Willy
