Hey Emeric,

On 12/3/15, 9:56 AM, "Emeric Brun" <[email protected]> wrote:

>
>But i notice some inconsistencies.
>
>Patch2 (crt conf keywoard):
>If the file without key extension is present, this file is loaded but
>also the multi_load is called.
>
>However in Patch3 (crt-list)
>If the file without key extension is present, this file is loaded but the
>multi_load is NOT called.

That shouldn¹t be the case. If the file w/o the key extension is present,
it will be found with stat, found not to be a directory, and then
ssl_sock_load_cert will return.


>
>There is a lot indentation issues in patch 2

Hopefully I¹ve fixed them in this next set of patches


>
>In patch 2 it remains a FIXME comment:
>// YANBZHU: FIXME

That was removed in patch 3, but I¹ve removed it from patch 2 a well.

The latest set of patches are attached to this as per Willy¹s suggestion.

-Dave

Attachment: 0001-MINOR-ssl-Added-cert_key_and_chain-struct.patch
Description: 0001-MINOR-ssl-Added-cert_key_and_chain-struct.patch

Attachment: 0002-MEDIUM-ssl-Added-support-for-creating-SSL_CTX-with-m.patch
Description: 0002-MEDIUM-ssl-Added-support-for-creating-SSL_CTX-with-m.patch

Attachment: 0003-MINOR-ssl-Added-multi-cert-support-for-crt-list-conf.patch
Description: 0003-MINOR-ssl-Added-multi-cert-support-for-crt-list-conf.patch

Reply via email to