Baptiste, could you please confirm that you're OK with merging these patches ? I think they're good but you're supposed to be the one who knows best. Also they might make you think about other areas possibly in need for other fixes.
Thanks, Willy On Fri, Apr 08, 2016 at 10:17:44PM +0200, Vincent Bernat wrote: > From: Vincent Bernat <[email protected]> > > Conforming to RFC 2535, section 6.1. This is not an important bug as > those fields don't seem to be set to something else than 0 and to be > checked on answers. > --- > include/types/dns.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/types/dns.h b/include/types/dns.h > index 757eaaf28d9a..98adc983bf44 100644 > --- a/include/types/dns.h > +++ b/include/types/dns.h > @@ -63,16 +63,16 @@ > /* DNS request or response header structure */ > struct dns_header { > unsigned short id:16; /* identifier */ > - unsigned char rd :1; /* recursion desired 0: no, 1: yes */ > - unsigned char tc :1; /* truncation 0:no, 1: yes */ > - unsigned char aa :1; /* authoritative answer 0: no, 1: yes */ > - unsigned char opcode :4; /* operation code */ > unsigned char qr :1; /* query/response 0: query, 1: response > */ > - unsigned char rcode :4; /* response code */ > - unsigned char z :1; /* no used */ > + unsigned char opcode :4; /* operation code */ > + unsigned char aa :1; /* authoritative answer 0: no, 1: yes */ > + unsigned char tc :1; /* truncation 0:no, 1: yes */ > + unsigned char rd :1; /* recursion desired 0: no, 1: yes */ > + unsigned char ra :1; /* recursion available 0: no, 1: yes */ > + unsigned char z :1; /* not used */ > unsigned char ad :1; /* authentic data */ > unsigned char cd :1; /* checking disabled */ > - unsigned char ra :1; /* recursion available 0: no, 1: yes */ > + unsigned char rcode :4; /* response code */ > unsigned short qdcount :16; /* question count */ > unsigned short ancount :16; /* answer count */ > unsigned short nscount :16; /* authority count */ > -- > 2.8.0.rc3 >
