Hi guys,
On Sat, Apr 23, 2016 at 09:21:53PM +0200, Lukas Tribus wrote:
> Hi David,
>
> thanks, that's extremely useful.
Yes indeed the bug is very clear after these details.
> Seems like we access memory that we are not supposed to access.
>
>
> I bisected this to eee5b512 ("MAJOR: http: move http_txn out of struct
> stream"),
> the backtrace looks like this:
Just this combined with log.c tells me we ought to check txn every time
we dereference it in log.c, I overlooked this during the split, taking
care of the other places :-(
I'm seeing 15 calls there that need to be adjusted. Status, cookies and
URI are the main victims. A lot of "txn->uri" can simply be changed to
"(txn && txn->uri)". I may try to do it tomorrow if nobody beats me by
doing it before.
Cheers,
Willy
