Hi Vincent,
On Wed, May 25, 2016 at 10:54:14PM +0200, Vincent Bernat wrote:
> ??? 25 mai 2016 22:15 +0200, Lukas Tribus <luky...@hotmail.com> :
>
> > DNS requests (using the internal resolver) are corrupted since commit
> > e2f84977165a ("BUG/MINOR: dns: fix DNS header definition").
> >
> > Fix it by defining the struct in network byte order, while complying
> > with RFC 2535, section 6.1.
>
> So sorry about that. It's quite odd since I tested the DNS resolution,
> but maybe not in the right way.
>
> The RFC says:
>
> 1 1 1 1 1 1
> 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
> | ID |
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
> |QR| Opcode |AA|TC|RD|RA| Z|AD|CD| RCODE |
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
> | QDCOUNT |
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
> | ANCOUNT |
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
> | NSCOUNT |
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
> | ARCOUNT |
> +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
>
> So, it's not about network byte order or not, this is just about bit
> numbering and I was so bad at it. I agree with your patch.
Great, thanks for the quicky verification!
I'm taking it as-is then.
Cheers,
Willy
