Hi Conrad, Thx for your patch, I'll review it later. Willy, please dont apply it for now since I have pending patches which touch this part of the code.
Baptiste Le 25 juin 2016 19:11, "Conrad Hoffmann" <con...@soundcloud.com> a écrit : > Hi, > > while poking around in the DNS response parsing, I thought this might be a > good idea, but not 100% sure about considerations that may have went into > the existing code. > > I was about to add more variables like `ancount` (e.g. `arcount`), then > realized it's all already there, in the struct dns_header. Downsides would > be having to remember to call ntohX() on integer members and heap access > vs. stack access. But I believe that's negligable. One could even keep the > `ancount` variable and just assign it once by reading the struct member, I > think the code simplification is still nice (especially the `flags` > checks). > > Just a thought, comments welcome. > > Cheers, > Conrad > -- > Conrad Hoffmann > Traffic Engineer > > SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany > > Managing Director: Alexander Ljung | Incorporated in England & Wales > with Company No. 6343600 | Local Branch Office | AG Charlottenburg | > HRB 110657B >
