Hi Cyril, On Fri, Jun 24, 2016 at 09:57:37PM +0200, Cyril Bonté wrote: > Hi all, > > Le 24/06/2016 à 21:33, James Brown a écrit : > > +1 I am also using a fake backend with no servers and a 503 errorfile, > > and it confuses everybody who looks at the config or the metrics. Being > > able to directly emit a 429 would be fantastic. > > Interestingly, it already exists since 1.6-dev2 [1] for "http-request deny" > but the documentation is absolutely missing. And it has recently been fixed > by Willy [2].
Yes indeed. I'm a bit upset not to have noticed the doc provided with this patch was incomplete : it only changed the list of possible return codes. It's not the first time we introduce new features without the respective doc, and I really think that in the future we'll simply revert the patch if we discover the doc is missing. A feature with no doc is only a selfish way for someone to have their own features in mainline in order to avoid having to maintain patches. But for features to be useful they need to be documented. Without doc they don't exist so they can be reverted. I encourage everyone to hunt for undocumented features. We may even discover that a part of the roadmap is already implemented. > Another point is that everything in the code seems to be ready to use the > same option with tarpit... except the configuration parser. Yep indeed. And it does not even support http-response either. That clearly looks like a quick hack that was rushed into mainline for a very specific use case, one more tempting reason to revert it :-( I've added the doc now, but no support for configuring it for tarpit. Thanks, Willy
