Odd looking code sequence in src/shctx.c:shsess_store()

[Frederik Deweerdt]

Hello,

shsess_store() has this odd looking code sequence (including line numbers):

333         /* it returns the already existing node
334            or current node if none, never returns null */
335         oldshsess = shsess_tree_insert(shsess);
336         if (oldshsess != shsess) {
337                 /* free all blocks used by old node */
338                 shsess_free(oldshsess);
339                 shsess = oldshsess;
340         }

Is the `shsess = oldshsess` assignment intentional? It looks like the code
might be leaking the blocks from shsess?

Thanks,
Frederik