On Wed, Oct 12, 2016 at 06:11:04PM +0200, Frederic Lecaille wrote:
> Everything is in the attached patch file.
> Please note that this patch has already been reviewed by Emeric Brun who is
> the peers protocol maintener.
Thank you very much for taking care of this one. I'd say it's a design
bug and not an implementation bug. And the fact that you were forced to
upgrade the protocol reflects this. For this reason, I think in a first
time I'll only merge it into 1.7, and maybe later after some observation
period *and* if there is a strong insisting demand we could consider
backporting it. But in general I'd rather keep protocol 2.0 for v1.6 and
protocol 2.1 for v1.7 as it's easier to track for users.
Oh I forgot to say, your patch looks good.