I admit I did not spend time on this part, especially I did most of the development on OpenBSD where pcre2 is compiled without jit support (due to sljit W^X "policy violation", I believe a couple of security oriented linux distros do the same ...), plus couple of quick tests on ubuntu.
Small detail I hardcoded lpcre2-posix ldflag due to this https://bugs.exim.org/show_bug.cgi?id=1924#c1 but that s ok as it is :-) Kindest regards. On 22 November 2016 at 10:11, Willy TARREAU <[email protected]> wrote: > Hi David, > > On Mon, Nov 21, 2016 at 09:42:10PM +0000, David CARLIER wrote: >> Hi, >> >> this patch attempts to bring pcre2 support to address the fact that pcre2 >> is installed more and more over pcre due to its security flaws. If >> accepted, it will be for 1.8, but I think somehow this is the good timing >> rather than now as pcre2 is not entirely spread in some of the main Linux >> distributions (current debian stable, centos without EPEL repository, ...). >> >> I willingly kept it the changes smooth, simple and close to the pcre's part. > (...) > > Thanks, your patch looks pretty clean so I'm keeping it for 1.8. Did you rnu > any performance test to compare PCRE and PCRE2 ? > > Willy
