Hi Everyone, Simon I've been playing with this patch today and I'm sorry to say that adding it to a 1.8 dev build as of today does not look to work.
I did have to manually update a few of the patch chunks so I'm willing to admit that it could be me that broke it and I will be having another go tomorrow unless Willy would be kind enough to update the 1.8 download for us with your patch already applied. However, the problem that I have now is that either the haproxy.stat file does not exist at all or I just keep getting: # echo "show info json" | socat /tmp/haproxy.stat stdio | python -m json.tool No JSON object could be decoded As I said I will try again tomorrow with a fresh brain and eyes. On 8 January 2017 at 10:52, Simon Horman <si...@horms.net> wrote: > Hi Willy, > > On Sun, Jan 08, 2017 at 07:37:24AM +0100, Willy Tarreau wrote: > > Hi Simon, > > > > On Wed, Jan 04, 2017 at 09:37:24AM +0100, Simon Horman wrote: > > > Hi, > > > > > > this short series is an RFC implementation of adding JSON format > > > output to show (info|stat). It also adds a new show schema json > > > stats command to allow retreival of the schema which describes > > > the JSON output of show (info|stat). > > (...) > > > > Thanks for this. I'm seeing in stats_emit_json_field_tags() that > > you have to emit the names of the various types, scopes, etc... > > I think this is the reason why you mention in patch 1 that it needs > > to be updated if the structure evolves. Probably that we should put > > these fields in an array declared just next to the enums. This way > > the declaration will be a bit more centralized. > > > > > Some areas for possible discussion: > > > * Use of STAT_STARTED in first patch > > > * Possible automatic generation of (part) of schema in 2nd patch > > > * Improved documentation > > > > For now I don't see anything there which needs further discussion, and > > nobody commented on your patches either, possibly indicating you're on > > the right track. If you want I can merge this series, it will be easier > > for you to update it later using incremental patches. > > > > > Some discussion of the size of JSON output is included as an appendix > > > to the changelog of the first patch. > > > > I'd prefer to integrate this with your commit message because it's quite > > useful as-is. > > > > Just let me know if you want the series to get merged or if you prefer > > to respin it. > > I'd prefer if you merged the series as-is > and I then provided incremental updates. > > -- > Simon Horman si...@horms.nl > Horms Solutions BV www.horms.nl > Parnassusweg 819, 1082 LZ Amsterdam, Netherlands > Tel: +31 (0)20 800 6155 Skype: horms7 > > -- With Kind Regards. Scott McKeown Loadbalancer.org http://www.loadbalancer.org Tel (UK) - +44 (0) 3303801064 (24x7) Tel (US) - +1 888.867.9504 (Toll Free)(24x7)
