On Mon, Jan 30, 2017 at 06:19:25PM +0100, [email protected] wrote:
> > Thanks for doing this, I think it's the right way to address it. Do you 
> > think
> > there is a way to emit a warning when the deprecated names are used ? That
> > would be nice for next version, though it's not critical.
> 
> 
> I don't known. I dont think that it is possible. I don't think that Lua
> can hook some object / function during parsing for sending warnings.
> 
> I hesitate to mention the deprecated in the documentation, but, finally
> I don't.

OK don't worry it was just a question just in case. The doc is sufficient.

> > I noticed a typo below, I'll try to think about fixing it by hand when
> > applying it :
> > 
> > > +.. js:attribute:: Map._ip
> > >  
> > >    See the HAProxy configuration.txt file, chapter "Using ACLs and 
> > > fetching
> > >    samples" ans subchapter "ACL basics" to understand this pattern 
> > > matching
> > >    method.
> > >  
> > > -.. js:attribute:: Map.str
> > > +  Note that :js:attr:`Map.p` is also available for compatibility.
> > 
> > That's "Map.ip".
> 
> Ok, do you want another patch.

No thank you, I already fixed it, it's just that I didn't have the time
to merge it yet (lots of local stuff to do).

thanks,
Willy

Reply via email to