Hi Dmitry,
On Wed, May 10, 2017 at 12:50:15PM +0300, Dmitry Sivachenko wrote:
> Hello,
>
> in Makefile I see some logic around USE_GETSOCKNAME define.
> But as far as I see, in sources you use getsockname() unconditionally.
>
> Is this an obsoleted define which should be removed from Makefile?
Ah you're right, I'm seeing it was rendered obsolete in 1.5-dev10 by
commit 59b9479 ("BUG/MEDIUM: stream_interface: restore get_src/get_dst")
and completely removed by the next cleanup commit. Amusingly, we continnued
to add it to new operating system definitions in the makefile.
Do you want to submit a cleanup patch ?
Thanks,
Willy
