The commit 201c07f68 ("MAJOR/REORG: dns: DNS resolution task and
requester queues") introduces a warning during compilation:
src/dns.c: In function ‘dns_resolve_recv’:
src/dns.c:487:6: warning: ‘need_resend’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
if (need_resend) {
^
This patch initialize the variable and remove the comment about it.
---
src/dns.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/dns.c b/src/dns.c
index cb7de6ab..78ee62bc 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -322,7 +322,7 @@ void dns_resolve_recv(struct dgram_conn *dgram)
struct dns_query_item *query;
unsigned char buf[DNS_MAX_UDP_MESSAGE + 1];
unsigned char *bufend;
- int fd, buflen, dns_resp, need_resend;
+ int fd, buflen, dns_resp, need_resend = 0;
unsigned short query_id;
struct eb32_node *eb;
struct lru64 *lru = NULL;
@@ -387,12 +387,6 @@ void dns_resolve_recv(struct dgram_conn *dgram)
dns_resp = dns_validate_dns_response(buf, bufend, resolution);
- /* treat errors first
- * need_resend flag could be set to 0 by default before the
'switch' and then
- * set to 1 only where needed, but I think it's better this way
to make people
- * aware they have to think twice how to set this flag when
updating this portion
- * of the code
- */
switch (dns_resp) {
case DNS_RESP_VALID:
need_resend = 0;
--
2.13.0
