Hi Manu,
Could you add a block '{ }' or move the comment on the comment on following
lines:
+ if (!((ssl_conf && ssl_conf->no_ca_names) ||
bind_conf->ssl_conf.no_ca_names))
+ /* set CA names fo client cert request,
function returns void */
+ SSL_CTX_set_client_CA_list(ctx,
SSL_load_client_CA_file(ca_file));
Is it quite confusing, and we want to avoid further mistakes.
A second point, i don't know which is the current policy about the keyword
prefix "no-" in configuration statements, but
we usually take care using this word.
Willy, would you clarify that point?
R,
Emeric
On 07/10/2017 05:45 PM, Emmanuel Hocdet wrote:
>
> Hi Bas,
>
>> Le 10 juil. 2017 à 17:05, Wolvers, Bas <[email protected]> a écrit :
>>
>> Hi Emmanuel,
>>
>> I finally found time to test your patch.
>>
>> It works, but you can't seem to turn it off.
>> no-ca-names seems to be active regardless of the option in the config file.
>>
>
> oops i fail the double negation.
> fix patch include.
>
>> I think I'll find time tomorrow to find out if it’s the global option or
>> not, but my time is a bit limited unfortunately.
>>
>> Best regards,
>>
>> Bas
>
> Thanks for testing!
>
> Manu
>
>
>
>
>
>
