Hi Dragan, The changes seem reasonable to me. A couple of things I should mention though.
The branch name for 3.2.12.12 should be in the same format as 3.2.10 (i.e. "v3.2.12"). The other thing is that the statement about 3.2.10 is not correct. The Trie data files were large and the solution had become unwieldly, so this has been removed from our repository. The Hash Trie however, is completely interface compatible and is available from 3.2.12 onwards. I suggest just stating "v3.2.12" and point out the new Hash Trie can be obtained by signing up for free at https://51degrees.com/products/store/on-premise-device-detection. Regards, Ben Shillito Developer O: +44 1183 287152 E: [email protected] T: @51Degrees -----Original Message----- From: Dragan Dosen [mailto:[email protected]] Sent: 02 October 2017 10:14 To: [email protected] Cc: Willy Tarreau <[email protected]>; Ben Shillito <[email protected]> Subject: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12 Hi all, I'm sending you a new set of patches -- fix for warning that appears when building with 51Degrees release that uses a new Hash Trie algorithm (release version 3.2.12.12): * BUILD/MINOR: 51d: fix warning when building with 51Degrees release version 3.2.12.12 * DOC: 51d: add 51Degrees git URL that points to release version 3.2.12.12 Patches can be backported in 1.7. Best regards, Dragan Dosen This email and any attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender immediately and do not disclose, use, store or copy the information contained herein. This is an email from 51Degrees.mobi Limited, 5 Charlotte Close, Reading. RG47BY. T: +44 118 328 7152; E: [email protected]; 51Degrees.mobi Limited t/as 51Degrees.
