Hi guys,
I can confirm that the patch is working. With the following loop I
replaced the string "SPIN_LOCK" with "HA_SPIN_LOCK" in every file where
it occured (I hope I got every file) and now compilation is working fine
(gnu sed is required):
for file in include/common/buffer.h include/common/hathreads.h
include/common/memory.h include/proto/applet.h
include/proto/channel.h include/proto/checks.h include/proto/fd.h
include/proto/stick_table.h include/proto/stream.h
include/proto/task.h src/applet.c src/checks.c src/compression.c
src/dns.c src/ev_epoll.c src/ev_kqueue.c src/ev_poll.c
src/ev_select.c src/fd.c src/flt_spoe.c src/hathreads.c
src/hlua_fcn.c src/hlua.c src/lb_chash.c src/lb_fas.c src/lb_fwlc.c
src/lb_fwrr.c src/lb_map.c src/listener.c src/map.c src/memory.c
src/mux_h2.c src/pattern.c src/peers.c src/proto_http.c src/queue.c
src/server.c src/stats.c src/stick_table.c src/stream.c src/task.c;
do gsed -i 's/SPIN_LOCK/HA_SPIN_LOCK/g' $file; done
Regards,
Daniel
Am 04.11.2017 um 17:10 schrieb Willy Tarreau:
Hi Olivier,
On Sat, Nov 04, 2017 at 03:17:59PM +0100, cognet wrote:
Oh too bad, we've already dealt with this a long time ago but now it
reappeared in new code. CCing Olivier. Olivier, in 2012 we already
faced this issue and addressed it in commit ee2663b ("BUILD: ssl:
NAME_MAX is not portable, use MAXPATHLEN instead") but resorting to
MAXPATHLEN.
The attached patch should fix that.
Thanks, now applied.
Sorry about that, I remember trying to figure out what the right spelling was,
quite obviously I was wrong :)
It's always the problem when several such variables work on a given platform.
But shouldn't it be PATH_MAX, which seems to be defined by POSIX ?
Very likely, yes, but I seem to remember something about it being declared
to be a very different size than the other ones on some older libc, which
might have explained why we sticked to MAXPATHLEN by then.
Willy
