Hi guys,

On Sat, Dec 23, 2017 at 08:58:43AM +0100, Cyril Bonté wrote:
> It looks to be a code regression.
> 
> Emeric, can you have a look at commit 5a1335110c ? It seems there was an
> unwanted change in the function call : srv_set_stopping() was replaced by
> srv_set_running()
> [...]
>  /* Marks the check <check> as valid and tries to set its server into
> stopping mode
> @@ -406,7 +371,7 @@ static void check_notify_stopping(struct check *check)
>       if ((s->agent.state & CHK_ST_ENABLED) && (s->agent.health <
> s->agent.rise))
>               return;
> 
> -     srv_set_stopping(s, (!s->track && !(s->proxy->options2 & 
> PR_O2_LOGHCHKS))
> ? check_reason_string(check) : NULL);
> +     srv_set_running(s, NULL, (!s->track && !(s->proxy->options2 &
> PR_O2_LOGHCHKS)) ? check : NULL);

Nice catch! Thanks Paul for your helpful report and Cyril for spotting
the bug. Now fixed, I can prepare 1.8.2 :-)

Willy

Reply via email to