Honestly, I didn't. If I right understand how export-dynamic works and how haproxy use integrated LUA, it shouldn't have any impact.
Honestly I see only one case when export-dynamic requests: when some application load haproxy over dlopen, and use some function from haproxy binary object. I expect that it isn't true, is it? -- wbr, Kirill > On 4 Jan 2018, at 01:10, Willy Tarreau <w...@1wt.eu> wrote: > > Hi Kirill, > > On Thu, Dec 28, 2017 at 04:13:38AM +0400, Kirill A. Korinsky wrote: >> Last macOS hasn't support export-dynamic, just remove it >> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index 2acf5028..19234897 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -630,7 +630,7 @@ check_lua_inc = $(shell if [ -d $(2)$(1) ]; then echo >> $(2)$(1); fi;) >> >> BUILD_OPTIONS += $(call ignore_implicit,USE_LUA) >> OPTIONS_CFLAGS += -DUSE_LUA $(if $(LUA_INC),-I$(LUA_INC)) >> -LUA_LD_FLAGS := -Wl,--export-dynamic $(if $(LUA_LIB),-L$(LUA_LIB)) >> +LUA_LD_FLAGS := $(if $(LUA_LIB),-L$(LUA_LIB)) > > Hmmm how can you be sure you didn't break anything else ? I'm pretty > sure that there was a reason for adding this --export-dynamic, maybe > certain things will still not work on your platform, or others won't > work at all. We need to run some checks before taking this one. > > I'm CCing Thierry in case he reminds why we need this. > > Regards, > Willy
