Hi Christopher, On Mon, Feb 19, 2018 at 03:24:09PM +0100, Christopher Faulet wrote: > Someone on discourse reports a problem with this patch: > > https://discourse.haproxy.org/t/random-sa-errors-with-haproxy-1-8-3/2116/6 > > I asked him to test the attached patch. But It could be cool to have more > feedback on the fix. The bug can easily be reproduced by closing a > connection opened with openssl s_client with a control-c.
Hehe so it seems I was not completely dumb when saying that the error used to compete with read0 in previous version ;-) It it's not enough, we may decide to fall back to the old method that was documented till OpenSSL 1.0.2 consisting in checking whether ret=0 was passed to SSL_get_error() or not to decide whether it's an error or a shutdown. But I think that in the current situation these ones will be equivalent for our use case anyway. Now applied, thanks! Willy
