Hi guys, On Thu, Mar 01, 2018 at 03:53:25PM +0100, Tim Düsterhus wrote: > Pavlos, > > Am 27.02.2018 um 22:50 schrieb Pavlos Parissis: > > BTW: The commit message is a bit misleading because If I don't read the > > code I will > > think that those options are enabled, which isn't true. So, you may want to > > mention they aren't > > enabled by default. > > > I'm not sure how I could put that succinctly into the first line of the > message. They are already too long. > > While I'm a huge proponent of clear messages I think in this case it's > easy to see in the diff that they are examples. I'll leave it up to > Willy to adapt the commit messages, if he considers them unclear, > instead of me sending even more patches to all the list subscriber's > mailboxes :-)
Well, let's not bikeshed on the contents of commit messages for patches that "only" contain extra documentation in config files in the end :-) I've just merged them now. Thanks! Willy
