Hi Emeric, > Le 18 avr. 2018 à 14:21, Emeric Brun <[email protected]> a écrit : > > On 04/16/2018 02:30 PM, Dmitry Sivachenko wrote: >> >>> On 07 Apr 2018, at 17:38, Emmanuel Hocdet <[email protected]> wrote: >>> >>> >>> I Andy >>> >>>> Le 31 mars 2018 à 16:43, Andy Postnikov <[email protected]> a écrit : >>>> >>>> I used to rework previous patch from Alpinelinux to build with latest >>>> stable libressl >>>> But found no way to run tests with openssl which is primary library as I >>>> see >>>> Is it possible to accept the patch upstream or get review on it? >>>> >>>> <fix-libressl-1.8.5.patch> >>> >>> >>> @@ -2208,7 +2223,7 @@ >>> #else >>> cipher = SSL_CIPHER_find(ssl, cipher_suites); >>> #endif >>> - if (cipher && SSL_CIPHER_get_auth_nid(cipher) == >>> NID_auth_ecdsa) { >>> + if (cipher && SSL_CIPHER_is_ECDSA(cipher)) { >>> has_ecdsa = 1; >>> break; >>> } >>> >>> No, it’s a regression in lib compatibility. >>> >> >> >> Hello, >> >> it would be nice if you come to an acceptable solution and finally merge >> LibreSSL support. >> There were several attempts to propose LibreSSL support in the past and >> every time discussion dies with no result. >> >> Thanks :) >> >> >> > > What do you think Manu? >
At least, regression should be fixed, it breaks openssl and boringssl build. (SSL_CIPHER_get_auth_nid has been added in LibreSSL 2.7) Otherwise the code only affects parts related to openssl, not boringssl. ++ Manu
