On 2018/4/30 04:58, Emeric Brun wrote: > Hi Patrick, > > On 04/29/2018 01:15 AM, Patrick Hemmer wrote: >> Previously these fetches would return empty results when HAProxy was >> compiled >> without the requisite SSL support. This results in confusion and problem >> reports from people who unexpectedly encounter the behavior. >> --- >> src/ssl_sock.c | 27 +++++++++++++++------------ >> 1 file changed, 15 insertions(+), 12 deletions(-) >> >> > Are you sure this path will not cause regression using boringssl or libressl > because i see some ifdef just based on openssl version. > > > R, > Emeric Yes. All this change does is copy/move the ifdefs around. Previously the ifdefs were inside the functions, so that if the functions were called, they'd return empty. The change moves the ifdefs to remove the function from the compiled code entirely. Yes it is possible that people who have been calling these functions when they don't have support for them will now get errors. But this is what was requested to happen by Willy.
-Patrick
