Hi Thierry,

On Mon, May 21, 2018 at 07:58:01PM +0200, Thierry Fournier wrote:
> Hi,
> 
> You will two patches in attachment.
> 
>  - The first fix some Lua error messages
 
thanks, I've merged this one already.

>  - The second fix a build error. This second should be reviewed because, I'm 
> not
>    so proud of solution :-) Note that this build error happens for compilation
>    without threads on macosx.

In my opinion this one looks wrong. Apparently there's a special case for
all_threads_mask when set to zero to indicate that no threads are enabled,
and it bypasses any such checks, which is better than setting it to ULONG_MAX.

I *suspect* it doesn't have any impact for now, except that since code relies
on !all_threads_mask it can progressively spread and break again later. So
please check by setting it to 0UL and if it works that's OK.

Thanks!
Willy

Reply via email to