On Tue, May 29, 2018 at 03:48:57PM -0600, Ben Draut wrote:
> >
> > So it looks all clean and works.
> > That said, I would add a couple of tests on strdup you have:
> > - newnameserver->conf.file = strdup("/etc/resolv.conf");
> > - newnameserver->id = strdup(address);
> > and of course, I would do the LIST_ADDQ after those checks.
> >
>
> Good catch, done.
Thank you Ben, now merged. I've adjusted the subsystem tag from "config"
to "dns" in the subject line though, it's more suitable and will help
quickly figure what it's about when reading git log.
> No problem, thanks for reviewing! Hopefully you guys get a break soon. Les
> vacances se rapprochent.. :)
Holidays are the moment where it's easier to stay focused on complex
stuff because there are less reasons to be disturbed ;-)
Willy
