On Wed, Jun 06, 2018 at 10:06:30AM -0400, Patrick Hemmer wrote: > > > On 2018/6/6 08:24, Olivier Houchard wrote: > > Hi Willy, > > > > On Wed, Jun 06, 2018 at 02:09:01PM +0200, Willy Tarreau wrote: > >> On Wed, Jun 06, 2018 at 02:04:35PM +0200, Olivier Houchard wrote: > >>> When building without threads enabled, instead of just using the global > >>> runqueue, just use the local runqueue associated with the only thread, as > >>> that's what is now expected for a single thread in > >>> prcoess_runnable_tasks(). > >> Just out of curiosity, shouldn't we #ifdef out the global runqueue > >> definition when running without threads in order to catch such cases > >> in the future ? > >> > > I think this is actually a good idea. > > My only concern is it adds quite a bit of #ifdef USE_THREAD, see the > > attached > > patch. > > > > Regards, > > > > Olivier > With this patch I'm getting: > > include/proto/task.h:138:26: error: use of undeclared identifier 'rqueue' > > With the previous patch, both reported issues are resolved. >
Hi Patrick, The last patch depended on the first one, so without it that failure is expected. Thanks a lot for reporting and testing. Willy, I think you can push both the patches. Regards, Olivier
