Hi Baptiste, On Wed, Aug 08, 2018 at 08:14:31PM +0200, Baptiste wrote: > Hi Willy, > > Could you please also backport those patches to 1.8? > Actually, 1.8 broke a haproxy's default behavior (when multiple servers > shares the same hostname) and that this patch helps fixing. > > here is the commit: 8e2d9430c0562ed74276d7f58e92706c384c0a36
As you know usually we don't backport features (been burnt too much in 1.5), but here if it fixes a regression, I guess it's a bit different. I've had a new look at the code and it looks safe. However could you please explain a bit more what exactly changed and how this broke, so that we can add the explanation in the backport commit message ? It's important because if anyone later faces an issue, we'll have to decide if we need to keep it or to revert, and in this case to know what it's supposed to fix. > Note the other patches have not been backported, and should have been: > 84221b4e9010810cf93b7ad7a31d825fa9fc26bf > 741e00a820ca23d3371a10587f5014c58ac14536 > e56fffd896fc29f886d5c55dc0930dc7e454b3c8 Thanks for the pointers. None of them was marked BUG, and no other one was marked as depending on them, that's why they were not spotted during the maintenance review cycle. Just checked, the last two are only cleanups, adjustments for comments or the removal of an unused macro, so they are not needed there at all. The first one was just backported however. Thanks! Willy
