Hi, On Sun, Sep 23, 2018 at 06:18:37PM +0200, Mildis wrote: > Hi, > > Here is a patch for a null-deref. > It checks if h2c exists before working on it. >
For these two patches, I'd prefer to have multiple exit labels than adding some "if" in the error exit path. It's important that the error path is clear, linear and without any ambiguity. For example, just add labels likes "fail_no_h2c" and "fail_no_queue" pointing to the return. That easily allows to later add intermediary branches if some other entries are allocated. Willy
