Hi Fred! On Thu, Oct 25, 2018 at 10:59:43AM +0200, Frederic Lecaille wrote: > Well, after having checked, haproxy could start with a cache bigger than > 2047 MB on my PC due to parsing issue. > > I provide three patches. The first fixes the "total-max-size" parsing > issue. The second patch is there to also parse "max-object-size" as an > unsigned int to avoid weird issues (implicit conversions). The last if > for the documentation update. > > Note that the maximum value of "max-object-size" is 4095/2 MB which may > be stored as an int. >
Good catch! Could you split the patches which contains shctx changes? Changes in the shctx API should have their own patches. You last patch seems to contain several fixes, 1 on the cache configuration parsing, and 2 others related to the way we test shctx_init. We mustn't have patches on ssl_sock.c in a patch related to the cache. Thanks. -- William Lallemand
