No sorry that was a bad patch, I thought earlier DragonFlyBSD did not
support but in fact it does.
On Mon, 12 Nov 2018 at 16:25, Willy TARREAU <[email protected]> wrote:
>
> Hi David,
>
> On Mon, Nov 12, 2018 at 04:16:17PM +0000, David CARLIER wrote:
> > Subject: [PATCH] BUILD/MEDIUM: DragonFlyBSD build fix
> >
> > This platform does not have particular build on its own, so it
> > just uses historically the FreeBSD's. Only it does not support
> > the thread/cpu binding.
>
> Is it only for threads that it doesn't support it or is it also
> for processes ? I'm just asking because if it's general, we'd
> better do it this way so that it remains consistent across all
> the code :
>
> diff --git a/include/common/compat.h b/include/common/compat.h
> index 8a7bbd5bf..8049a6095 100644
> --- a/include/common/compat.h
> +++ b/include/common/compat.h
> @@ -162,6 +162,11 @@
> #define HA_HAVE_CRYPT_R
> #endif
>
> +/* DragonFly doesn't have CPU affinity */
> +#ifndef __DragonFly__
> +#undef USE_CPU_AFFINITY
> +#endif
> +
> #endif /* _COMMON_COMPAT_H */
>
> /*
>
> But if it's only for threads, we can indeed proceed just at this place,
> but then we have no option for emitting a warning (maybe that's not
> dramatic). However then please fold the two ifdefs into one :
>
> > #ifdef USE_CPU_AFFINITY
> > +#ifndef __DragonFly__
>
> => #if defined(USE_CPU_AFFINITY) && !defined(__DragonFly__)
>
> Thanks,
> Willy
