On Mon, Dec 31, 2018 at 08:36:01PM -0500, Alex Zorin wrote: > On Tue, Jan 1, 2019, at 12:32 AM, Willy Tarreau wrote: > > You're welcome. I was about to apply it until I figured that a doc update > > is missing. Please add an entry to configuration.txt for this new keyword > > (and take care of respecting the alphabetical order). > > Okay, updated the docs.
Perfect, this looks very good, and generally well documented (code, doc, commit), thank you! I've merged it now. > On reflection I was not able to discern the distinction of the sample fetch > keyword list and the ACL keyword list in payload.c. I hope that having added > this to the sample fetch list only was correct, even though it does not match > the example set by "req_ssl_sni". You're absolutely right. The ACLs are here for historic compatibility, they provide a default matching method, which most of the time is now properly picked thanks to the output type of the sample. Another difference often lies in the keyword name. For example "req_ssl_sni" used to be the name used in ACLs, while the sample fetch function is "req.ssl_sni", so there's nothing which can map one to the other automatically. The good choice is indeed to only add new keywords to the sample fetch list as you did, so that they can be used everywhere. Thanks, Willy
