Quick clarification on the previous message.

The code emitting the warning is almost assuredly here: 
https://github.com/haproxy/haproxy/blob/ed7a066b454f09fee07a9ffe480407884496461b/src/proto_htx.c#L3242
 not in proto_http.c, seeing how this is in htx mode not http mode.

I've traced the issue to likely being caused by the following condition false:

https://github.com/haproxy/haproxy/blob/202c6ce1a27c92d21995ee82c71b2f70c636e3ea/src/htx.c#L93

We are dealing with a lot of larger responses (PNGs, 50-100KB/request on avg) 
with perhaps 10 simultaneous initial requests on the same h2 connection being 
very common. That sounds like I may in fact need to tweak some buffer settings 
somewhere. In http/1.1 mode, these requests were spread out across four 
connections with browsers blocking until the previous connection finished.

The documentation is only somewhat helpful for tune.bufsize and 
tune.maxrewrite, http/2 and large requests. If this isn't a bug, would someone 
be willing to offer some guidance into good values for these buffer sizes?

Thanks for your help!

Best,
Luke

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, January 18, 2019 1:10 PM, Luke Seelenbinder 
<[email protected]> wrote:

> Hello all,
> 

> I just rolled out 1.9.2 compiled from the official tarball to a subset of our 
> servers, and I'm observing some odd behavior in the logs. I'm seeing the 
> following warning (with accompanying warnings about failed hdr rewrites in 
> the stats page):
> 

> Proxy foo failed to add or set the response header 'bar' for request #1380. 
> You might need to increase tune.maxrewrite
> 

> I've tweaked tune.maxrewrite to 2048 with no apparent affect (it was not 
> previously set). The further odd thing is that the header is present on the 
> client side (seemingly every time). This is does not happen with an identical 
> config in 1.8.x (obviously sans h2 on both ends & option http-use-htx).
> 

> Any ideas regarding what I should investigate? The line emitting the warning 
> seems to be 
> https://github.com/haproxy/haproxy/blob/master/src/proto_http.c#L1630.
> 

> I'm happy to try patches additional configuration changes if that would 
> assist. I assume it's something slightly amiss in the HTX setup or my 
> configuration thereof.
> 

> Best,
> Luke
> 

> —
> Luke Seelenbinder
> Stadia Maps | Founder
> stadiamaps.com

Attachment: publickey - [email protected] - 0xB23C1E8A.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to