On Mon, Jan 21, 2019 at 04:39:53AM +0100, Willy Tarreau wrote:
> Hi,
>
> On Thu, Jan 17, 2019 at 08:21:39AM +0000, Uman Shahzad wrote:
> > If we fail to initialize pollers due to fdtab/fdinfo/polled_mask
> > not getting allocated, we free any of those that were allocated
> > and exit. However the ordering was incorrect, and there was an old
> > unused and unreachable "fail_cache" path as well.
>
> Good catch. The issue was introduced in 1.9-dev with this patch :
>
> cb92f5c ("MINOR: pollers: move polled_mask outside of struct fdtab.")
>
> 1.8 is OK. I'll mention this in the commit message so that we don't
> try to backport it too far.
By the way, I will even adjust it a little bit because there is still
a mistake at the end : if no poller works, we return zero without
freeing anything (this never happens). We need to remove the return 0
at the end and to keep free(fdinfo).
Willy
