Hi Pieter, On Fri, Jan 25, 2019 at 01:01:19AM +0100, PiBa-NL wrote: > Hi List, > > Attached a regtest which i 'think' should pass. > > ** s1 0.0 === expect tbl.dec[1].key == ":authority" > ---- s1 0.0 EXPECT tbl.dec[1].key (host) == ":authority" failed > > It seems to me the Host <> Authority conversion isn't happening properly.? > But maybe i'm just making a mistake in the test case... > > I was using HA-Proxy version 2.0-dev0-f7a259d 2019/01/24 with this test. > > The test was inspired by the attempt to connect to mail.google.com , as > discussed in the "haproxy 1.9.2 with boringssl" mail thread.. Not sure if > this is the main problem, but it seems suspicious to me..
It's not as simple, :authority is only required for CONNECT and is optional for other methods with Host as a fallback. Clients are encouraged to use it instead of the Host header field, according to paragraph 8.1.2.3, but there is nothing indicating that a gateway may nor should build one from scratch when translating HTTP/1.1 to HTTP/2. In fact the authority part is generally not present in the URIs we receive as a gateway, so what we'd put there would be completely reconstructed from the host header field. I don't even know if all servers are fine with authority only instead of Host. Please note, I'm not against changing this, I just want to be sure we actually fix something and that we don't break anything. Thus if you have any info indicating there is an issue with this one missing, it could definitely help. Thanks! Willy
