I got it to compile by changing the name of the ip_v variable and everywhere it
is used in connection.c.
conn_recv_netscaler_cip
Line 792: uint8_t ip_vPSO;
Line 860: ip_vPSO = (*line & 0xf0) >> 4;
Line 862: if (ip_vPSO == 4) {
Line 892: else if (ip_vPSO == 6) {
Patrick Overbey
Fiserv
-----Original Message-----
From: Overbey, Patrick (Sioux Falls)
Sent: Wednesday, April 03, 2019 4:50 PM
To: Willy Tarreau <[email protected]>
Cc: [email protected]; [email protected]
Subject: RE: Upcoming haproxy build fixes for Cygwin & AIX
Actually, here is the error. The warning was just the last thing that printed
to the screen.
In file included from /usr/include/netinet/tcp.h:113,
from include/common/compat.h:32,
from src/connection.c:15:
src/connection.c: In function 'conn_recv_netscaler_cip':
src/connection.c:792:10: error: expected '=', ',', ';', 'asm' or
'__attribute__' before '.' token
uint8_t ip_v;
^~~~
src/connection.c:792:10: error: expected expression before '.' token
src/connection.c:860:2: error: 'ip_ff' undeclared (first use in this function);
did you mean 'ip_fv'?
ip_v = (*line & 0xf0) >> 4;
^~~~
Patrick Overbey
Fiserv
-----Original Message-----
From: Willy Tarreau [mailto:[email protected]]
Sent: Wednesday, April 03, 2019 3:50 PM
To: Overbey, Patrick (Sioux Falls)
<[email protected]<mailto:[email protected]>>
Cc: [email protected]<mailto:[email protected]>;
[email protected]<mailto:[email protected]>
Subject: Re: Upcoming haproxy build fixes for Cygwin & AIX
⚠ EXTERNAL MESSAGE – Think Before You Click
On Wed, Apr 03, 2019 at 08:40:35PM +0000, Overbey, Patrick (Sioux Falls) wrote:
> It looks the same to me. Thanks.
>
> In file included from src/connection.c:17:
> src/connection.c: In function '__initcb_1302':
> include/common/initcall.h:128:11: warning: cast between incompatible
> function ty
At least the line has changed, indicating that the macro correctly made its way
to the code. I need to scratch my head now.
> pes from 'void (*)(struct sample_fetch_kw_list *)' to 'void (*)(void
> *, void *, void *)' [-Wcast-function-type]
> .fct = (void (*)(void *,void *,void *))function, \
> ^
> include/common/initcall.h:146:2: note: in expansion of macro
> '__DECLARE_INITCALL '
> __DECLARE_INITCALL(__VA_ARGS__)
> ^~~~~~~~~~~~~~~~~~
> include/common/initcall.h:158:2: note: in expansion of macro
> '_DECLARE_INITCALL'
>
> _DECLARE_INITCALL(stage, __LINE__, function, arg1, 0, 0)
> ^~~~~~~~~~~~~~~~~
> src/connection.c:1302:1: note: in expansion of macro 'INITCALL1'
> INITCALL1(STG_REGISTER, sample_register_fetches,
> &sample_fetch_keywords); ^~~~~~~~~
> gmake: *** [Makefile:996: src/connection.o] Error 1
Note, I'm only seeing a warning and not the error here. So I don't understand
why the compilation stopped. And I don't understand why the warning above
wasn't automatically disabled since the compiler supports it.
Willy
