Hi Tim, Thank you for the comment. I will have them fix. But I have a question, I am not sure which subsystem should I put it in? Looks like I have more than one subsystem touched.
Thank you. Regards, Alexander Liu On Sat, Apr 27, 2019 at 7:57 AM Tim Düsterhus <[email protected]> wrote: > > Alec, > > Am 26.04.19 um 22:10 schrieb Alec Liu: > > Here is the patch for adding upstream socks4 proxy support. > > Please help to review it, thank you. > > > > I can't comment on the technical side, but a few comments on the > 'process' side: > > 1. You did not update the documentation yet (doc/configuration.txt) > 2. The subsystem is missing from your commit message. It probably should > be: MEDIUM: connection: Add socks4 support for upstream connections > 3. The two commits should be merged into a single one. > 4. Please mention the issue number in the commit message: 'See issue #82' > > Best regards > Tim Düsterhus
