On 4/30/19 11:24 AM, Илья Шипицин wrote:
you are right.
let us exclude that particular test from freebsd (what your patch
exactly does)
Ok Thank you Ilya.
Willy could you merge this patch if we decide to disable this reg test
on FreeBSD systems. It had already been fixed to make it succeed on a
FreeBSD version I do not remember (see commit 9ffb88d). This issue came
back with 12.0 version with a similar regex. So I think it is time to
disabled this reg test for FreeBSD. Furthermore, it was originally
dedicated to Linux.
If we do not decide to disable it on FreeBSD, we must rewrite the syslog
message regexes to make them more permissive as with 9ffb88d commit.
Fred.
>From 0989af55e5a3d2d87defd64a68a78ff1057ad5db Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= <[email protected]>
Date: Mon, 29 Apr 2019 16:10:12 +0200
Subject: [PATCH] REGTEST: Make this reg test be Linux specific.
This patch reverts 9ffb88 commit (REGTEST: Be less Linux specific with a syslog
regex.) and makes this script be Linux specific.
---
reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc b/reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc
index ffd31235e..e3c959f16 100644
--- a/reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc
+++ b/reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc
@@ -1,6 +1,7 @@
varnishtest "Check: smptchk option"
feature ignore_unknown_macro
+#EXCLUDE_TARGETS=freebsd,osx,generic
#REGTEST_TYPE=slow
barrier b cond 3
@@ -29,7 +30,7 @@ syslog S3 -level notice {
recv
expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Proxy be3 started"
recv
- expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Health check for server be3/srv3 failed, reason: Layer4 .* check duration: [[:digit:]]+ms, status: 0/1 DOWN."
+ expect ~ "[^:\\[ ]\\[${h1_pid}\\]: Health check for server be3/srv3 failed, reason: Layer4 connection problem, info: \"General socket error \\(Network is unreachable\\)\", check duration: [[:digit:]]+ms, status: 0/1 DOWN."
} -start
syslog S4 -level notice {
--
2.11.0
