Hi Patrick,

On Mon, Jun 03, 2019 at 05:47:25PM -0400, Patrick Hemmer wrote:
> In haproxy 1.9.8, if you do `tcp-request session set-var()` with a variable
> in any scope other than sess, it segfaults.
> For example:
> tcp-request session set-var(txn.foo) ...
> tcp-request session set-var(req.foo) ...
> 
> * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS
> (code=1, address=0x268)
>     frame #0: 0x000000010019c6a7 haproxy`sample_store_stream(name="foo",
> scope=SCOPE_TXN, smp=0x00007ffeefbfef48) at vars.c:442
>    439         case SCOPE_RES:
>    440         default:         vars = &smp->strm->vars_reqres; break;
>    441         }
> -> 442         if (vars->scope != scope)
>    443             return 0;
>    444
>    445         HA_RWLOCK_WRLOCK(VARS_LOCK, &vars->rwlock);
> Target 0: (haproxy) stopped.

Indeed, good catch! Now fixed in mainline. Thank you!
Willy

Reply via email to