On Thu, Jun 13, 2019 at 03:57:04PM +0000, Ben Shillito wrote: > Also, after thinking earlier about making it more obvious that it is a dummy > library, I have attached a patch which adds "(dummy library)" to the output > of REGISTER_BUILD_OPTS macro.
Ah perfect, I also wanted to do it but considered it of lower importance than the remaining stuff so it could be postponed. I've merged it now, thank you. > I thought about pushing a warning when the dummy library is used just to be > super obvious. Don't know what you think of that? No it's not a good idea. We're trying to make sure that *any* single warning must be addressable by the end user, otherwise people get used to seeing them and to ignore them. If people build with the dummy lib and complain, they'll send their haproxy -vv, you see "dummy" there it becomes "you don't need to run with this, please prove the problem still happens without", end of the story. I asked about these libs for convenience for *developers* not for users. But if it causes warnings in all our builds, it will end up being disabled which is counter productive. Cheers, Willy
