Hi guys, On Thu, Jun 27, 2019 at 03:55:54PM +0500, ???? ??????? wrote: > ??, 27 ???. 2019 ?. ? 15:33, Lukas Tribus <[email protected]>: > > > Hello, > > > > On Thu, 27 Jun 2019 at 08:43, ???? ??????? <[email protected]> wrote: > > >> However this commit also changes error handling with OpenSSL: > > >> > > >> > > https://github.com/haproxy/haproxy/commit/54832b97c65c43ee50b6661a9b4b05885427b5e9#diff-cc9b3f376afbc81cf478eeac17839172L5533 > > >> > > >> > > >> Can you clarify if the OpenSSL change was intentional and if yes, > > elaborate? > > > > > > > > > it was intentional. libressl does not support "packet_size" there. > > > however, openssl is fine with the above way > > > > Then I have to criticize that commit message. > > > > you are right, commit messages is not my best. > sorry about that > > anyway, if you think it is wrong, you are welcome to provide a fix > (sometimes, I do wrong things, I'm ok with that)
Ilya, don't take it bad, bugs always happen and the problem with bugs is to detect them then to figure how to address them. In this regard, Lukas is absolutely right. We all know it takes time to learn how to do better commits, and guess what, very often when I work on a bug, end up on a commit, and start to shout "who the hell did that crap?" I discover it's me and I'm totally ashamed of the lack of context in my own message despite probably being the most annoying one about it. This is really something we're extremely picky about as it directly affects our ability to maintain robust stable branches so that users can sleep while their load balancers swallow requests. However please do not just give up suggesting that anyone can take over your patch. It doesn't work this way, everyone is responsible in one way or another for his/her contributions and their impact (and seeing how you care about getting Travis to work fine, I'm pretty sure you feel bad when you see that one of your changes does not work as expected). Please just work with Lukas to try to remember why you thought the change was OK and how Lukas figured this one broke something. Once the context is properly recalled, you may together figure the corner case that's not covered anymore and how to properly address it. Then either of you proposes the patch and this bug doesn't exist anymore. Bugs introduced are not a judgement of anyone's work quality. However the ability to fix one's bug definitely is. That's why we don't care when bugs are accidently introduced, and value the fixes above anything. Over time it pays off. Thanks, Willy
