Hi Fred, On Thu, Jul 04, 2019 at 02:37:55PM +0200, Frederic Lecaille wrote: > On 7/4/19 1:36 PM, Olivier Houchard wrote: > > Hi William, > > > > On Wed, Jul 03, 2019 at 04:52:14PM +0000, William Dauchy wrote: > > > Hello, > > > > > > On haproxy v2.0.x, while using tfo option in default-server: > > > default-server inter 5s fastinter 1s fall 3 slowstart 20s observe > > > layer7 error-limit 5 on-error fail-check pool-purge-delay 10s tfo > > > we are getting: > > > 'default-server inter' : 'tfo' option is not accepted in default-server > > > sections. > > > > > > from https://cbonte.github.io/haproxy-dconv/2.0/configuration.html#5.2-tfo > > > > > > Is tfo excluded from default-server options? > > > > There's indeed no reason to disallow tfo on default-server, it was an > > oversight, it is fixed in master with commit > > 8d82db70a5f32427fb592a947d2a612bcb01d95e, and should be backported in 2.0 > > before the next release. > > > > Regards, > > > > Olivier > > > > This makes me think we should perhaps add "no-tfo" option as this is already > done for several other "server" options. > > The attached patch should do the trick. > > Fred.
Ooops, very good point. I just pushed your patch, thanks a lot ! Olivier