Hi Ilya, Willy,
Op 13-10-2019 om 19:30 schreef Илья Шипицин:
https://cirrus-ci.com/github/haproxy/haproxy
I'll bisect if noone else knows what's going on
@IIlya, thanks for checking my favorite platform, FreeBSD ;).
@Willy, this 30ee1ef
<http://git.haproxy.org/?p=haproxy.git;a=commit;h=30ee1ef> (MEDIUM: h2:
use the normalized URI encoding for absolute form requests) commit
'broke' the expect value of the vtest, i don't know why other platforms
don't see the same change in syslog output though.. Anyhow this is the
output i get when running the
/reg-tests/connection/proxy_protocol_random_fail.vtc
**** Slog_1 0.033 syslog|<134>Oct 14 19:56:34 haproxy[78982]: ::1:47040
[14/Oct/2019:19:56:34.391] ssl-offload-http~ ssl-offload-http/http
0/0/0/0/0 503 222 - - ---- 1/1/0/0/0 0/0 "POST https://[::1]:47037/1
HTTP/2.0"
** Slog_1 0.033 === expect ~ "ssl-offload-http/http .* \"POST /[1-8]
HTTP/(2\\.0...
---- Slog_1 0.033 EXPECT FAILED ~ "ssl-offload-http/http .* "POST
/[1-8] HTTP/(2\.0|1\.1)""
If i change the vtc vtest file from:
expect ~ "ssl-offload-http/http .* \"POST /[1-8] HTTP/(2\\.0|1\\.1)\""
To:
expect ~ "ssl-offload-http/http .* \"POST
https://[[]::1]:[0-9]{1,5}/[1-8] HTTP/(2\\.0|1\\.1)\""
or:
expect ~ "ssl-offload-http/http .* \"POST
https://[[]${h1_ssl_addr}]:${h1_ssl_port}/[1-8] HTTP/(2\\.0|1\\.1)\""
Then the test succeeds for me... but now the question is, should or
shouldn't the scheme and host be present in the syslog output on all
platforms.? Or should the regex contain a (optional?) check for this
extra part? (Also note that even with these added variables in my second
regext attempt its still using accolades around the IPv6 address.. not
sure if all machines would use ipv6 for their localhost connection..)
Regards,
PiBa-NL (Pieter)
