My comment is wrong. A server weight can have a value of 256. Please update the comment :)
Baptiste On Mon, Oct 21, 2019 at 4:35 PM Christopher Faulet <[email protected]> wrote: > Le 21/10/2019 à 16:20, Baptiste a écrit : > > Thx to 2 people who spotted a bug in my patch, (missing parenthesis). > > > > here is the updated version. > > > > On Mon, Oct 21, 2019 at 3:59 PM Baptiste <[email protected] > > <mailto:[email protected]>> wrote: > > > > hi there, > > > > Following up some recent discussion about SRV record's weight and > server > > weight in HAProxy, we spotted a bug in the current code: when weight > in SRV > > record is set to 0, then server weight in HAProxy was 1... > > Thanks to Willy for proposing the solution applied into that patch. > > > > Baptiste > > > > Baptiste, > > I don't know if the comment is wrong or not. But with your patch, the > weight is > now between 0 and 256. The function server_parse_weight_change_request() > is ok > with that. So I can amend your comment if you want. I just want to have a > confirmation. > > -- > Christopher Faulet >
