Hi Romain, On Fri, Oct 25, 2019 at 12:55:31PM +0000, Morotti, Romain D wrote: > Hello, > > Patch attached. Adding an option "http-check send-name-header <header>". > It adds a header per server in healthchecks, similar usage to > "http-send-name-header". Built and tested locally.
So I'm still not totally fond of it to be honest, at an era where people are using server-templates to dynamically populate their farms with fixed server names, and will instead replace the FQDN at run time when populating their farms but I do see at least some consistency in your use case. I thought we could start better with limited extra effort by adding one argument to the servers, that could later be changed from the CLI so that users can decide how they update their farms. Also for all those using DNS, it's actually the server's FQDN and not its internal config name which will be required to be sent. As such I still think that this feature as-is will quickly be deprecated and dropped in future releases by lack of relevant use case. If others think we should take this patch as a temporary step, I'm not fundamentally against it, I'm just seeing it as a temporary hack. In this case it will be desirable to write more than just a one-liner for the keyword documentation entry and explain what it really does so that it doesn't drive some users to wrong conclusions. What do others think ? Igor maybe you have a particular opinion on this one ? Baptiste, anything from the dynamic use cases you're aware of ? Thanks, Willy
