On Fri, Jan 17, 2020 at 04:35:38AM +0000, Elliot Otchet wrote: > Great feedback guys. Thank you. > I think I've incorporated all of it including > WIlly's requests for:- A better commit message- Fixing the unnecessary edits > (spaces vs tabs)- strcomp instead of strcasecmp > Tim's request for: - Correcting the documentation bracket bugs - Fixing the > typo I introduced > - Updating to his suggested explanation of the feature - An argument > validator for the format parameter. > An updated patch for your consideration. Let me know what you think.
Looks good, thanks. I'm just turning the tag from medium to minor since the risk of breakage is infinitesimal. Thanks for indicating in the commit message the possible room left for improvement. I'm seeing that the patch's author is just "degroens", may I place your real name instead ? (aliases are not much welcome nor very polite when people want to discuss a patch later). So just let me know and I'll merge it. Thank you, Willy
